Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646280
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock |
| Date | 2017-05-21 09:50 +0200 |
| Message-ID | <tJtMJ-4Tk-9@gated-at.bofh.it> (permalink) |
| References | <tJneh-kw-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun 21-05-17 00:45:46, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > The function get_free_pipe_id_locked() is called from > goldfish_pipe_open() with a lock is held, so we should > use GFP_ATOMIC instead of GFP_KERNEL. Why is GFP_NOWAIT insufficient? Does this path needs an access to memory reserves? > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/platform/goldfish/goldfish_pipe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c > index 2de1e60..5f36721 100644 > --- a/drivers/platform/goldfish/goldfish_pipe.c > +++ b/drivers/platform/goldfish/goldfish_pipe.c > @@ -704,7 +704,7 @@ static int get_free_pipe_id_locked(struct goldfish_pipe_dev *dev) > /* Reallocate the array */ > u32 new_capacity = 2 * dev->pipes_capacity; > struct goldfish_pipe **pipes = > - kcalloc(new_capacity, sizeof(*pipes), GFP_KERNEL); > + kcalloc(new_capacity, sizeof(*pipes), GFP_ATOMIC); > if (!pipes) > return -ENOMEM; > memcpy(pipes, dev->pipes, sizeof(*pipes) * dev->pipes_capacity); > -- Michal Hocko SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock Wei Yongjun <weiyj.lk@gmail.com> - 2017-05-21 02:50 +0200
Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock Michal Hocko <mhocko@kernel.org> - 2017-05-21 09:50 +0200
Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock Michal Hocko <mhocko@kernel.org> - 2017-05-22 14:00 +0200
Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-22 20:50 +0200
csiph-web