Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

From	Christian König <deathsimple@vodafone.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code
Date	2017-05-20 13:50 +0200
Message-ID	<tJb3r-Re-3@gated-at.bofh.it> (permalink)
References	<tHS2S-2t1-5@gated-at.bofh.it> <tIZOG-16K-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 20.05.2017 um 01:48 schrieb Lyude:
> This is the first part of me going through and cleaning up the IRQ handling
> code for radeon, since after taking a look at it the other day while trying to
> debug something I realized basically all of the code was copy pasted
> everywhere, and quite difficult to actually read through.
>
> Will come up with something for r600 and cik once I've got the chipsets on hand
> to test with.
>
> Lyude (3):
>    drm/radeon: Cleanup display interrupt handling for evergreen, si
>    drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
>    drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si

I don't have time to do a line by line review, but what I saw looked 
very good to me.

So the whole seres is Acked-by: Christian König <christian.koenig@amd.com>.

BTW: You don't want to take a look at the other hw generations as well?

Regards,
Christian.

>
>   drivers/gpu/drm/radeon/evergreen.c      | 943 ++++++--------------------------
>   drivers/gpu/drm/radeon/radeon.h         |  27 +-
>   drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
>   drivers/gpu/drm/radeon/si.c             | 655 +++++-----------------
>   4 files changed, 344 insertions(+), 1316 deletions(-)
>

Thread

[PATCH 0/3] Cleanup evergreen/si IRQ handling code Lyude <lyude@redhat.com> - 2017-05-16 23:20 +0200
  [PATCH 2/3] drm/radeon: Cleanup HDMI audio interrupt handling for evergreen Lyude <lyude@redhat.com> - 2017-05-16 23:20 +0200
  [PATCH v2 2/3] drm/radeon: Cleanup HDMI audio interrupt handling for evergreen Lyude <lyude@redhat.com> - 2017-05-20 01:50 +0200
  [PATCH v2 3/3] drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si Lyude <lyude@redhat.com> - 2017-05-20 01:50 +0200
  [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code Lyude <lyude@redhat.com> - 2017-05-20 01:50 +0200
    Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code Christian König <deathsimple@vodafone.de> - 2017-05-20 13:50 +0200
      Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code Lyude Paul <lyude@redhat.com> - 2017-05-22 16:00 +0200
      Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code Alex Deucher <alexdeucher@gmail.com> - 2017-05-24 20:40 +0200

csiph-web