Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646097

Re: [GIT PULL] KVM fixes for v4.12-rc2

Show all headers | View raw

On 20/05/17 00:21, Linus Torvalds wrote:
> So I noticed that my diffstat didn't match either the KVM or the Xen pull.
> 
> The *reason* seems to be that both Radim and Juergen have enabled the
> "patience" diff, because if I add "--patience" to the diff line, I get
> the same numbers you guys report.
> 
> On Fri, May 19, 2017 at 11:43 AM, Radim Krčmář <rkrcmar@redhat.com> wrote:
>>
>>  28 files changed, 297 insertions(+), 125 deletions(-)
> 
> Without "--patience" (the default) I get:
> 
>  28 files changed, 292 insertions(+), 120 deletions(-)
> 
> which is close, but not the exact same thing.
> 
> So I don't mind people using the patience version of the diffing code,
> but on the whole it's a loss as often as it is a win, so I'm wondering
> _why_ you do this? Is there some other project that has started
> suggesting using the patience diff (either with a command line option
> or by just doing
> 
>   git config diff.algorithm patience
> 
> anyway, it's not a big deal, I'm just curious..

In my case it was a patch which was much easier to review using the
patience diff. I just didn't switch back afterwards (what I did now).


Juergen

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] KVM fixes for v4.12-rc2 Radim Krčmář <rkrcmar@redhat.com> - 2017-05-19 20:50 +0200
  Re: [GIT PULL] KVM fixes for v4.12-rc2 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-20 00:30 +0200
    Re: [GIT PULL] KVM fixes for v4.12-rc2 Juergen Gross <jgross@suse.com> - 2017-05-20 13:00 +0200
      Re: [GIT PULL] KVM fixes for v4.12-rc2 Radim Krčmář <rkrcmar@redhat.com> - 2017-05-22 16:40 +0200

csiph-web