Re: [PATCH] kernel: bpf: remove dead code

From	Daniel Borkmann <daniel@iogearbox.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kernel: bpf: remove dead code
Date	2017-05-22 19:10 +0200
Message-ID	<tJZ0e-8sT-23@gated-at.bofh.it> (permalink)
References	<tJWc4-6Hl-67@gated-at.bofh.it> <tJWF4-6Ra-25@gated-at.bofh.it> <tJWYq-6XB-17@gated-at.bofh.it> <tJYnx-80c-53@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/22/2017 06:27 PM, David Miller wrote:
[...]
> Ok I understand the issue now.  Thanks for explaining.
>
> I guess a hard-coded value of 2 and an adjusted comment above the
> assignment of ip_align is the way to go.
>
> I'll push the following, thanks everyone:
>
> ====================
> net: Make IP alignment calulations clearer.
>
> The assignmnet:
>
> 	ip_align = strict ? 2 : NET_IP_ALIGN;
>
> in compare_pkt_ptr_alignment() trips up Coverity because we can only
> get to this code when strict is true, therefore ip_align will always
> be 2 regardless of NET_IP_ALIGN's value.
>
> So just assign directly to '2' and explain the situation in the
> comment above.
>
> Reported-by: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>

Yeah, that's fine, thanks!

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Thread

[PATCH] kernel: bpf: remove dead code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-22 16:10 +0200
  Re: [PATCH] kernel: bpf: remove dead code David Miller <davem@davemloft.net> - 2017-05-22 16:40 +0200
    Re: [PATCH] kernel: bpf: remove dead code Daniel Borkmann <daniel@iogearbox.net> - 2017-05-22 17:00 +0200
      Re: [PATCH] kernel: bpf: remove dead code David Miller <davem@davemloft.net> - 2017-05-22 18:30 +0200
        Re: [PATCH] kernel: bpf: remove dead code Daniel Borkmann <daniel@iogearbox.net> - 2017-05-22 19:10 +0200
    Re: [PATCH] kernel: bpf: remove dead code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-22 17:00 +0200

csiph-web