Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647124

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Arnd Bergmann <arnd@arndb.de> writes:

> The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA,
> but it just causes needless warnings:
>
> drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable]
> drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: 'pl111_modeset_init' defined but not used [-Werror=unused-function]
>
> This removes the #ifdef instead, and adds a dependency on ARM_AMBA to
> only let us build the driver when the base support is enabled.
>
> Unfortunately, this requires removing one redundant 'select ARM_AMBA'
> line from mach-s3c64xx to avoid a circular dependency.
>
> It might be good to allow manually enabling ARM_AMBA when COMPILE_TEST
> is turned on, but that should be a separate patch and may cause other
> build regressions.

If I understand the Kconfig, you're effectively disabling the build on
COMPILE_TEST && !ARM.  I'd rather that we just fix up the warnings, so
that people can keep build-testing DRM drivers:

https://patchwork.kernel.org/patch/9737857/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/pl111: add ARM_AMBA dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-22 17:30 +0200
  Re: [PATCH] drm/pl111: add ARM_AMBA dependency Eric Anholt <eric@anholt.net> - 2017-05-22 18:30 +0200
    Re: [PATCH] drm/pl111: add ARM_AMBA dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-22 23:50 +0200
      Re: [PATCH] drm/pl111: add ARM_AMBA dependency Eric Anholt <eric@anholt.net> - 2017-05-23 00:10 +0200
        Re: [PATCH] drm/pl111: add ARM_AMBA dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-24 18:00 +0200
  Re: [PATCH] drm/pl111: add ARM_AMBA dependency Krzysztof Kozlowski <krzk@kernel.org> - 2017-05-22 18:40 +0200
    Re: [PATCH] drm/pl111: add ARM_AMBA dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-22 23:40 +0200
      Re: [PATCH] drm/pl111: add ARM_AMBA dependency Krzysztof Kozlowski <krzk@kernel.org> - 2017-05-23 13:20 +0200
        Re: [PATCH] drm/pl111: add ARM_AMBA dependency Krzysztof Kozlowski <krzk@kernel.org> - 2017-05-23 13:30 +0200
        Re: [PATCH] drm/pl111: add ARM_AMBA dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-23 13:30 +0200

csiph-web