Re: [PATCH] net: atheros: atl2: don't return zero on failure path in atl2_probe()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: atheros: atl2: don't return zero on failure path in atl2_probe()
Date	2017-05-22 18:10 +0200
Message-ID	<tJY4a-7To-23@gated-at.bofh.it> (permalink)
References	<tIZ2i-w0-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sat, 20 May 2017 01:52:11 +0300

> If dma mask checks fail in atl2_probe(), it breaks off initialization,
> deallocates all resources, but returns zero.
> 
> The patch adds proper error code return value and
> make error code setup unified.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Looks good, applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: atheros: atl2: don't return zero on failure path in atl2_probe() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-05-20 01:00 +0200
  Re: [PATCH] net: atheros: atl2: don't return zero on failure path  in atl2_probe() David Miller <davem@davemloft.net> - 2017-05-22 18:10 +0200

csiph-web