Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1647009
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: fec: add post PHY reset delay DT property |
| Date | 2017-05-22 16:50 +0200 |
| Message-ID | <tJWOK-6Ut-27@gated-at.bofh.it> (permalink) |
| References | <tJRFp-3IZ-47@gated-at.bofh.it> <tJW2n-6oO-27@gated-at.bofh.it> <tJWc4-6Hl-69@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, May 22, 2017 at 04:00:47PM +0200, Quentin Schulz wrote:
> Hi Andrew
>
> On 22/05/2017 15:57, Andrew Lunn wrote:
> > On Mon, May 22, 2017 at 11:15:17AM +0200, Quentin Schulz wrote:
> >> Some PHY require to wait for a bit after the reset GPIO has been
> >> toggled. This adds support for the DT property `phy-reset-post-delay`
> >> which gives the delay in milliseconds to wait after reset.
> >>
> >> If the DT property is not given, no delay is observed. Post reset delay
> >> greater than 1000ms are invalid and are default to 1ms.
> >
> > Hi Quentin
> >
> > If it is invalid, please return -EINVAL.
> >
>
> Just copying the wording and behavior of phy-reset-duration. Should we
> then change the behavior of phy-reset-duration as well to return -EINVAL
> in that case or I just leave both as is?
No, you cannot change phy-reset-duration. There could be device tree
blobs out in the wild with invalid phy-reset-duration which silently
get converted to 1000ms by the code. You cannot break them.
However, you can prevent new additions which add invalid
phy-reset-post-delay.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: fec: add post PHY reset delay DT property Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-05-22 11:20 +0200
Re: [PATCH] net: fec: add post PHY reset delay DT property Andrew Lunn <andrew@lunn.ch> - 2017-05-22 16:00 +0200
Re: [PATCH] net: fec: add post PHY reset delay DT property Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-05-22 16:10 +0200
Re: [PATCH] net: fec: add post PHY reset delay DT property Andrew Lunn <andrew@lunn.ch> - 2017-05-22 16:50 +0200
RE: [PATCH] net: fec: add post PHY reset delay DT property Andy Duan <fugang.duan@nxp.com> - 2017-05-23 04:10 +0200
csiph-web