Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646989

Re: RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net()

Show key headers only | View raw

>> Omit an extra message for a memory allocation failure in this function.
> 
> The change itself is harmless,  but I'm curious about the "extra"
> part: "extra" from what? If this happens, hopefully this will be logged
> somewhere? Note that this type of (infrequent) logging noise is useful
> in some cases, e.g., with 8ce675ff, when one is trying to do the
> post-mortem of where things first went wrong.

Do you find information from a Linux allocation failure report sufficient
for such an use case?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] RDS: Adjustments for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 16:20 +0200
  [PATCH 3/3] RDS: TCP: Delete an error message for a failed memory  allocation in rds_tcp_init_net() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 16:20 +0200
    Re: [PATCH 3/3] RDS: TCP: Delete an error message for a failed  memory allocation in rds_tcp_init_net() Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2017-05-22 16:30 +0200
      Re: RDS: TCP: Delete an error message for a failed memory allocation  in rds_tcp_init_net() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 16:40 +0200
        Re: RDS: TCP: Delete an error message for a failed memory allocation  in rds_tcp_init_net() Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2017-05-22 16:50 +0200
  [PATCH 2/3] RDS: IB: Improve a size determination in rds_ib_add_one() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 16:20 +0200
    Re: [PATCH 2/3] RDS: IB: Improve a size determination in  rds_ib_add_one() Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-05-22 21:30 +0200

csiph-web