Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646848

Re: [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

Show all headers | View raw

Hi,

On Mon, May 22, 2017 at 07:32:49AM -0500, Kim Phillips wrote:
> On Thu, 18 May 2017 18:24:32 +0100
> Will Deacon <will.deacon@arm.com> wrote:
> > +/* Perf callbacks */
> > +static int arm_spe_pmu_event_init(struct perf_event *event)
> > +{
> > +	u64 reg;
> > +	struct perf_event_attr *attr = &event->attr;
> > +	struct arm_spe_pmu *spe_pmu = to_spe_pmu(event->pmu);
> > +
> > +	/* This is, of course, deeply driver-specific */
> > +	if (attr->type != event->pmu->type)
> > +		return -ENOENT;
> > +

[trimming other return sites]

> I've consistently brought up lack of proper user error messaging in all
> previous submissions of this driver:
> 
... and we've consistently explained why logging such things to dmesg by
default will not fly. As before, while we call these return codes error
values, they are *not* errors in the same sense as pr_err().

> 6 apr 2017 (PATCH v2 series):
> https://lkml.org/lkml/2017/4/6/790

Please consult my replies to this:

https://lkml.org/lkml/2017/4/6/796
https://lkml.org/lkml/2017/4/7/246

... we can add a pr_debug() for these cases, as that will be guarded by
dynamic debug, and won't be pointlessly spamming the dmesg.

Anything beyond that simply will not fly.

> AFAICT, my comments hold, yet the driver still gets resubmitted without
> them being addressed.  How do we get out of this loop?

We've repeatedly explained why the approach you suggest is not feasible.
Perhaps you could try to explain why our approach doesn't seem feasible
to you.

Thanks,
Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Add support for the ARMv8.2 Statistical Profiling Extension Will Deacon <will.deacon@arm.com> - 2017-05-18 19:30 +0200
  [PATCH v3 3/5] perf/core: Add PERF_AUX_FLAG_COLLISION to report colliding samples Will Deacon <will.deacon@arm.com> - 2017-05-18 19:30 +0200
  [PATCH v3 1/5] genirq: export irq_get_percpu_devid_partition to modules Will Deacon <will.deacon@arm.com> - 2017-05-18 19:30 +0200
  [PATCH v3 2/5] perf/core: Export AUX buffer helpers to modules Will Deacon <will.deacon@arm.com> - 2017-05-18 19:30 +0200
  [PATCH v3 5/5] dt-bindings: Document devicetree binding for ARM SPE Will Deacon <will.deacon@arm.com> - 2017-05-18 19:30 +0200
  [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension Will Deacon <will.deacon@arm.com> - 2017-05-18 19:30 +0200
    Re: [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2 Statistical  Profiling Extension Thomas Gleixner <tglx@linutronix.de> - 2017-05-21 22:40 +0200
      Re: [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2 Statistical  Profiling Extension Will Deacon <will.deacon@arm.com> - 2017-05-22 13:10 +0200
    Re: [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2  Statistical Profiling Extension Kim Phillips <kim.phillips@arm.com> - 2017-05-22 14:40 +0200
      Re: [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2 Statistical  Profiling Extension Mark Rutland <mark.rutland@arm.com> - 2017-05-22 14:50 +0200
        Re: [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2  Statistical Profiling Extension Kim Phillips <kim.phillips@arm.com> - 2017-05-22 17:50 +0200
          Re: [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2 Statistical  Profiling Extension Mark Rutland <mark.rutland@arm.com> - 2017-05-22 18:30 +0200
            Re: [PATCH v3 4/5] drivers/perf: Add support for ARMv8.2  Statistical Profiling Extension Kim Phillips <kim.phillips@arm.com> - 2017-05-23 01:30 +0200

csiph-web