Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646692
| From | Jose Abreu <Jose.Abreu@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 00/10] Introduce new mode validation callbacks |
| Date | 2017-05-22 12:10 +0200 |
| Message-ID | <tJSrL-4mR-5@gated-at.bofh.it> (permalink) |
| References | <tIEqR-2II-3@gated-at.bofh.it> <tJQpX-2Fw-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Daniel,
On 22-05-2017 08:56, Daniel Vetter wrote:
> On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote:
>> This series is a follow up from the discussion at [1]. We start by
>> introducing crtc->mode_valid(), encoder->mode_valid() and
>> bridge->mode_valid() callbacks which will be used in followup
>> patches and also by cleaning the documentation a little bit. This
>> patch is available at [2] and the series depends on it.
>>
>> We proceed by introducing new helpers to call this new callbacks
>> at 1/10.
>>
>> At 2/10 a helper function is introduced that calls all mode_valid()
>> from a set of bridges.
>>
>> Next, at 3/10 we modify the connector probe helper so that only modes
>> which are supported by a given bridge+encoder+crtc combination are
>> probbed.
>>
>> At 4/10 we call all the mode_valid() callbacks for a given pipeline,
>> except the connector->mode_valid one, so that the mode is validated.
>> This is done before calling mode_fixup().
>>
>> Finally, from 5/10 to 10/10 we use the new callbacks in drivers that
>> can implement it.
>>
>> [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_9702233_&d=DwIDAw&c=DPL6_X_6JkXFx7AXWqB0tg&r=WHDsc6kcWAl4i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw&m=k-nrzbop60GvJmHyy9k4CfcDFfpSPQEZVA4lpNurIXo&s=rkPEIZmYcjgdVLR6jC_5SMwjNRc_Ye9r4RO95axhtwQ&e=
>> [2] https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_archives_dri-2Ddevel_2017-2DMay_141761.html&d=DwIDAw&c=DPL6_X_6JkXFx7AXWqB0tg&r=WHDsc6kcWAl4i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw&m=k-nrzbop60GvJmHyy9k4CfcDFfpSPQEZVA4lpNurIXo&s=z5gY8e9Yii5F4HDTa-MQojgFHenigkUt2aKPaGGVQLg&e=
>>
>> Jose Abreu (10):
>> drm: Add drm_{crtc/encoder/connector}_mode_valid()
>> drm: Introduce drm_bridge_mode_valid()
>> drm: Use new mode_valid() helpers in connector probe helper
>> drm: Use mode_valid() in atomic modeset
>> drm: arc: Use crtc->mode_valid() callback
>> drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback
>> drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback
>> drm/arm: malidp: Use crtc->mode_valid() callback
>> drm/atmel-hlcdc: Use crtc->mode_valid() callback
>> drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks
> Looks all real nice, I think a bit more time to get acks/reviews/tested-by
> for the driver conversions and I'll go and vacuum this all up.
Yeah, I would really like someone to test these, especially the
drivers part.
>
> Thanks a lot for doing this.
No problem :) Thanks!
Best regards,
Jose Miguel Abreu
> -Daniel
>
>> Cc: Carlos Palminha <palminha@synopsys.com>
>> Cc: Alexey Brodkin <abrodkin@synopsys.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Dave Airlie <airlied@linux.ie>
>> Cc: Andrzej Hajda <a.hajda@samsung.com>
>> Cc: Archit Taneja <architt@codeaurora.org>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>
>> drivers/gpu/drm/arc/arcpgu_crtc.c | 29 ++++---
>> drivers/gpu/drm/arm/malidp_crtc.c | 11 ++-
>> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 +--
>> drivers/gpu/drm/bridge/analogix-anx78xx.c | 13 ++-
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++-------
>> drivers/gpu/drm/drm_atomic_helper.c | 76 +++++++++++++++++-
>> drivers/gpu/drm/drm_bridge.c | 33 ++++++++
>> drivers/gpu/drm/drm_crtc_helper_internal.h | 13 +++
>> drivers/gpu/drm/drm_probe_helper.c | 105 ++++++++++++++++++++++++-
>> drivers/gpu/drm/imx/dw_hdmi-imx.c | 4 +-
>> drivers/gpu/drm/meson/meson_dw_hdmi.c | 2 +-
>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +-
>> drivers/gpu/drm/vc4/vc4_crtc.c | 13 ++-
>> drivers/gpu/drm/vc4/vc4_dpi.c | 13 ++-
>> include/drm/bridge/dw_hdmi.h | 2 +-
>> include/drm/drm_bridge.h | 2 +
>> 16 files changed, 280 insertions(+), 87 deletions(-)
>>
>> --
>> 1.9.1
>>
>>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 00/10] Introduce new mode validation callbacks Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
[PATCH v4 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
[PATCH v4 02/10] drm: Introduce drm_bridge_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
[PATCH v4 04/10] drm: Use mode_valid() in atomic modeset Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
[PATCH v4 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
[PATCH v4 03/10] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
Re: [PATCH v4 03/10] drm: Use new mode_valid() helpers in connector probe helper Daniel Vetter <daniel@ffwll.ch> - 2017-05-22 10:00 +0200
[PATCH v4 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
Re: [PATCH v4 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback Neil Armstrong <narmstrong@baylibre.com> - 2017-05-24 14:40 +0200
[PATCH v4 08/10] drm/arm: malidp: Use crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
[PATCH v4 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
[PATCH v4 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-19 03:00 +0200
Re: [PATCH v4 00/10] Introduce new mode validation callbacks Daniel Vetter <daniel@ffwll.ch> - 2017-05-22 10:00 +0200
Re: [PATCH v4 00/10] Introduce new mode validation callbacks Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-22 12:10 +0200
Re: [PATCH v4 00/10] Introduce new mode validation callbacks Daniel Vetter <daniel@ffwll.ch> - 2017-05-22 17:40 +0200
Re: [PATCH v4 00/10] Introduce new mode validation callbacks Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-23 16:50 +0200
Re: [PATCH v4 00/10] Introduce new mode validation callbacks Daniel Vetter <daniel@ffwll.ch> - 2017-05-24 14:20 +0200
csiph-web