Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646663

Re: [PATCH 1/2] libsas: Don't process sas events in static works

Show all headers | View raw

On 22/05/2017 06:54, wangyijing wrote:
>> I also think for safety this should use a mempool that guarantees that
>> > events can continue to be processed under system memory pressure.
> What I am worried about is it's would still fail if the mempool is used empty during memory pressure.
>
>> > Also, have you considered the case when a broken phy starts throwing a
>> > constant stream of events? Is there a point at which libsas should
>> > stop queuing events and disable the phy?
> Not yet, I didn't find this issue in real case, but I agree, it's really a problem in some broken
> hardware, I think it's not a easy problem, we could improve it step by step.
>
> Thanks!
> Yijing.
>

I have seen this scenario on our development board when we have a bad 
physical cable connection - the PHY continually goes up and down in a loop.

So, in this regard, it is worth safeguarding against this scenario.

John

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] libsas: Don't process sas events in static works Yijing Wang <wangyijing@huawei.com> - 2017-05-20 08:40 +0200
  Re: [PATCH 1/2] libsas: Don't process sas events in static works Dan Williams <dan.j.williams@intel.com> - 2017-05-21 05:50 +0200
    Re: [PATCH 1/2] libsas: Don't process sas events in static works wangyijing <wangyijing@huawei.com> - 2017-05-22 08:00 +0200
      Re: [PATCH 1/2] libsas: Don't process sas events in static works John Garry <john.garry@huawei.com> - 2017-05-22 11:30 +0200
        Re: [PATCH 1/2] libsas: Don't process sas events in static works wangyijing <wangyijing@huawei.com> - 2017-05-23 08:50 +0200

csiph-web