[PATCH V1] leds: pca955x: Correct I2C Functionality

From	Tin Huynh <tnhuynh@apm.com>
Newsgroups	linux.kernel
Subject	[PATCH V1] leds: pca955x: Correct I2C Functionality
Date	2017-05-22 11:30 +0200
Message-ID	<tJRP3-3Ve-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The driver checks an incorrect flag of functionality of adapter.
When a driver requires i2c_smbus_read_byte_data and
i2c_smbus_write_byte_data, it should check I2C_FUNC_SMBUS_BYTE_DATA
instead I2C_FUNC_I2C.
This patch fixes the problem.

Signed-off-by: Tin Huynh <tnhuynh@apm.com>
---
 drivers/leds/leds-pca955x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
index 78a7ce8..9a87311 100644
--- a/drivers/leds/leds-pca955x.c
+++ b/drivers/leds/leds-pca955x.c
@@ -285,7 +285,7 @@ static int pca955x_probe(struct i2c_client *client,
 			"slave address 0x%02x\n",
 			client->name, chip->bits, client->addr);
 
-	if (!i2c_check_functionality(adapter, I2C_FUNC_I2C))
+	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
 		return -EIO;
 
 	if (pdata) {
-- 
1.7.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH V1] leds: pca955x: Correct I2C Functionality Tin Huynh <tnhuynh@apm.com> - 2017-05-22 11:30 +0200
  Re: [PATCH V1] leds: pca955x: Correct I2C Functionality Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-05-22 21:10 +0200

csiph-web