Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index()

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index()
Date	2017-05-18 21:50 +0200
Message-ID	<tIzAR-7Ri-13@gated-at.bofh.it> (permalink)
References	<tIhkB-1NU-9@gated-at.bofh.it> <tIzAR-7Ri-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 18 May 2017 12:40:02 -0700
Doug Anderson <dianders@chromium.org> wrote:

> Hi,
> 
> This appears to have been introduced in 2009 by commit afbab76a62b6
> ("ring-buffer: have read page swap increment counter with page
> entries"), which removed the user of the function but not the function
> itself.  If folks were so inclined, this could be picked back to
> linux-stable, but I'm not sure it's worth it.

It doesn't do anything but waste some disk space in the source
repository. It's a static inline function, which means it's not created
unless something calls it.

Thus, not worth the stable churn.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ring-buffer: Remove unused function __rb_data_page_index() Matthias Kaehlcke <mka@chromium.org> - 2017-05-18 02:20 +0200
  Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index() Doug Anderson <dianders@chromium.org> - 2017-05-18 21:50 +0200
    Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index() Doug Anderson <dianders@chromium.org> - 2017-05-18 21:50 +0200
    Re: [PATCH] ring-buffer: Remove unused function  __rb_data_page_index() Steven Rostedt <rostedt@goodmis.org> - 2017-05-18 21:50 +0200

csiph-web