Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1644822
| From | David Carrillo-Cisneros <davidcc@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode |
| Date | 2017-05-18 20:30 +0200 |
| Message-ID | <tIylr-6r1-9@gated-at.bofh.it> (permalink) |
| References | <tIl4S-4Ep-3@gated-at.bofh.it> <tIl4S-4Ep-19@gated-at.bofh.it> <tIwjE-58a-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, May 18, 2017 at 9:13 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Wed, May 17, 2017 at 09:16:02PM -0700, David Carrillo-Cisneros wrote:
>
> SNIP
>
>>
>> @@ -2107,42 +2109,80 @@ struct feature_ops {
>> int (*process)(struct feat_fd *fd, void *data);
>> const char *name;
>> bool full_only;
>> + int record_type;
>> };
>>
>> -#define FEAT_OPA(n, func) \
>> - [n] = { .name = #n, .write = write_##func, .print = print_##func }
>> -#define FEAT_OPP(n, func) \
>> - [n] = { .name = #n, .write = write_##func, .print = print_##func, \
>> - .process = process_##func }
>> -#define FEAT_OPF(n, func) \
>> - [n] = { .name = #n, .write = write_##func, .print = print_##func, \
>> - .process = process_##func, .full_only = true }
>> +#define FEAT_OPP(n, func, __full_only) \
>> + [HEADER_##n] = { \
>> + .name = __stringify(HEADER_##n), \
>> + .write = write_##func, \
>> + .print = print_##func, \
>> + .full_only = __full_only, \
>> + .process = process_##func, \
>> + .record_type = PERF_RECORD_HEADER_##n \
>> + }
>> +
>> +#define FEAT_OPN(n, func, __full_only) \
>> + [HEADER_##n] = { \
>> + .name = __stringify(HEADER_##n), \
>> + .write = write_##func, \
>> + .print = print_##func, \
>> + .full_only = __full_only, \
>> + .process = process_##func \
>> + }
>
> you're adding record_type, which should not be a reason
> to rename FEAT_* macros.. please do that in the separate
> patch and state reason in changelog
will do
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 7/7] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-05-18 06:20 +0200
Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-18 18:20 +0200
Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-05-18 20:40 +0200
Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-18 18:20 +0200
Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-05-18 20:30 +0200
Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-18 18:20 +0200
Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-18 18:20 +0200
Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-05-18 18:20 +0200
Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-05-18 20:30 +0200
csiph-web