Re: [PATCH 5/7] perf header: use struct feat_fd for process and read

From	David Carrillo-Cisneros <davidcc@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/7] perf header: use struct feat_fd for process and read
Date	2017-05-18 20:10 +0200
Message-ID	<tIy25-6hh-9@gated-at.bofh.it> (permalink)
References	<tIl4S-4Ep-3@gated-at.bofh.it> <tIl4S-4Ep-9@gated-at.bofh.it> <tIwjE-58a-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 18, 2017 at 9:13 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Wed, May 17, 2017 at 09:16:00PM -0700, David Carrillo-Cisneros wrote:
>> As preparation for using header records in pipe mode, replace
>> int fd with struct feat_fd fd in process and read functions for
>> all header record types.
>>
>> To reduce the boiler plate, define and use the FEAT_PROCESS_STR_FUN
>> macro for the common case of header records that are a simple string.
>
> please separate those changes, AFAICS it's following:
>   - using feat_fd in read functions
>   - reworking do_read_string function
>   - replacing readn with new do_read* functions
>   - adding FEAT_PROCESS_STR_FUN

Will do.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/7] perf header: use struct feat_fd for process and read David Carrillo-Cisneros <davidcc@google.com> - 2017-05-18 06:20 +0200
  Re: [PATCH 5/7] perf header: use struct feat_fd for process and read Jiri Olsa <jolsa@redhat.com> - 2017-05-18 18:20 +0200
    Re: [PATCH 5/7] perf header: use struct feat_fd for process and read David Carrillo-Cisneros <davidcc@google.com> - 2017-05-18 20:10 +0200

csiph-web