Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file

From	Waiman Long <longman@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file
Date	2017-05-18 18:00 +0200
Message-ID	<tIw0h-4M2-15@gated-at.bofh.it> (permalink)
References	<tHoo9-lZ-3@gated-at.bofh.it> <tHoo9-lZ-1@gated-at.bofh.it> <tIePM-8wt-19@gated-at.bofh.it>
Organization	Red Hat

Show all headers | View raw

On 05/17/2017 05:36 PM, Tejun Heo wrote:
> Hello, Waiman.
>
> On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote:
>> The debug cgroup currently resides within cgroup-v1.c and is enabled
>> only for v1 cgroup. To enable the debug cgroup also for v2, it
>> makes sense to put the code into its own file as it will no longer
>> be v1 specific. The only change in this patch is the expansion of
>> cgroup_task_count() within the debug_taskcount_read() function.
>>
>> Signed-off-by: Waiman Long <longman@redhat.com>
> I don't mind enabling the debug controller for v2 but let's please
> hide it behind an unwieldy boot param / controller name so that it's
> clear that its interface isn't expected to be stable.
>
> Thanks.
>
The controller name is "debug" and so it is obvious what this controller
is for. However, the config prompt "Example controller" is indeed vague
in meaning. So we can make the prompt more descriptive here. As for the
boot param, are you saying something like "cgroup_debug" has to be
specified in the command line even if CGROUP_DEBUG config is there for
the debug controller to be enabled? I am fine with that if you think it
is necessary.

Regards,
Longman

Thread

[RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file Waiman Long <longman@redhat.com> - 2017-05-15 15:40 +0200
  Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file Tejun Heo <tj@kernel.org> - 2017-05-17 23:40 +0200
    Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file Waiman Long <longman@redhat.com> - 2017-05-18 17:40 +0200
    Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file Waiman Long <longman@redhat.com> - 2017-05-18 18:00 +0200
      Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file Tejun Heo <tj@kernel.org> - 2017-05-19 21:30 +0200
        Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file Waiman Long <longman@redhat.com> - 2017-05-19 21:40 +0200
          Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file Tejun Heo <tj@kernel.org> - 2017-05-19 22:30 +0200

csiph-web