Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1644605

Re: spidev: Adjust five checks for null pointers

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject Re: spidev: Adjust five checks for null pointers
Date 2017-05-18 16:40 +0200
Message-ID <tIuKS-3YK-17@gated-at.bofh.it> (permalink)
References <tI9n3-4Ud-3@gated-at.bofh.it> <tI9n3-4Ud-1@gated-at.bofh.it> <tIrMZ-1IL-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
> 
> Please fix however you're sending things out to avoid this noise.

The Git software generated such extra information because my commit message
contained a few special characters.


>> The script “checkpatch.pl” pointed information out like the following.
>>
>> Comparison to NULL could be written !…
>>
>> Thus fix the affected source code places.
> 
> This changelog does not describe any purpose in making this change,
> we could equally well say the exact opposite.  Why should we do this?

How do you think about to reduce the usage of the preprocessor symbol “NULL”?

Can it help if the source code is a little bit shorter after the
proposed adjustment?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] spidev: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-17 17:50 +0200
  Re: [PATCH 2/2] spidev: Adjust five checks for null pointers Mark Brown <broonie@kernel.org> - 2017-05-18 13:30 +0200
    Re: spidev: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-18 16:40 +0200
      Re: spidev: Adjust five checks for null pointers Mark Brown <broonie@kernel.org> - 2017-05-22 14:40 +0200

csiph-web