[PATCH] usb: chipidea: debug: check before accessing ci_role

From	Michael Thalmeier <michael.thalmeier@hale.at>
Newsgroups	linux.kernel
Subject	[PATCH] usb: chipidea: debug: check before accessing ci_role
Date	2017-05-18 16:30 +0200
Message-ID	<tIuBb-3UN-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

ci_role BUGs when the role is >= CI_ROLE_END.

Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
---
 drivers/usb/chipidea/debug.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
index 6d23eed..1c31e8a 100644
--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data)
 {
 	struct ci_hdrc *ci = s->private;
 
-	seq_printf(s, "%s\n", ci_role(ci)->name);
+	if (ci->role != CI_ROLE_END)
+		seq_printf(s, "%s\n", ci_role(ci)->name);
 
 	return 0;
 }
-- 
2.9.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: chipidea: debug: check before accessing ci_role Michael Thalmeier <michael.thalmeier@hale.at> - 2017-05-18 16:30 +0200
  Re: [PATCH] usb: chipidea: debug: check before accessing ci_role Michael Thalmeier <michael.thalmeier@hale.at> - 2017-05-19 10:20 +0200

csiph-web