Re: [v3,1/2] mwifiex: initiate card-specific work atomically

From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [v3,1/2] mwifiex: initiate card-specific work atomically
Date	2017-05-18 15:50 +0200
Message-ID	<tItYu-3le-1@gated-at.bofh.it> (permalink)
References	<tCpkR-4KF-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Brian Norris <briannorris@chromium.org> wrote:
> The non-atomic test + set is a little awkward here, and it technically
> means we might double-schedule work unnecessarily. AFAICT, this is not
> really a problem, since the extra "work" will be a no-op (the flag(s)
> will be cleared by then), but it's still an anti-pattern.
> 
> Rewrite this to use the atomic test_and_set_bit() helper instead.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

2 patches applied to wireless-drivers-next.git, thanks.

21f569af9ab3 mwifiex: initiate card-specific work atomically
6d7d579a8243 mwifiex: pcie: add card_reset() support

-- 
https://patchwork.kernel.org/patch/9706851/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [v3,1/2] mwifiex: initiate card-specific work atomically Kalle Valo <kvalo@codeaurora.org> - 2017-05-18 15:50 +0200

csiph-web