Re: [PATCH 1/3] livepatch: Add force sysfs attribute

From	Miroslav Benes <mbenes@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] livepatch: Add force sysfs attribute
Date	2017-05-18 15:30 +0200
Message-ID	<tItF7-37o-3@gated-at.bofh.it> (permalink)
References	<tIspI-2kb-17@gated-at.bofh.it> <tIspL-2kb-97@gated-at.bofh.it> <tItlM-2Zs-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 18 May 2017, Libor Pechacek wrote:

> On Thu 18-05-17 14:00:41, Miroslav Benes wrote:
> >
> > +		pr_info("no patching in progress. Force not allowed\n");
> 
> proposing smoother wording and information sharing
> pr_info("no patching in progress, forced action (%d) ineffective", val);

That is better. Thanks.

> > +		return -EINVAL;
> > +	}
> > +
> > +	switch (val) {
> 
> I felt strong confusion for a while looking at a function what does nothing. A
> comment that this is intentionally an empty shell, at this stage, would be
> welcome.

Yes, I wanted to keep that sysfs glue separate from both implementations 
to make the review easier. Despite the ugly outcome. And it is confusing.

Comment sounds good.

Thanks,
Miroslav

> > +	default:
> > +		return -EINVAL;
> > +	}
> > +
> > +	return count;
> > +}

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] livepatch: Introduce force sysfs attribute Miroslav Benes <mbenes@suse.cz> - 2017-05-18 14:10 +0200
  [PATCH 3/3] livepatch: force transition process to finish Miroslav Benes <mbenes@suse.cz> - 2017-05-18 14:10 +0200
    Re: [PATCH 3/3] livepatch: force transition process to finish Libor Pechacek <lpechacek@suse.com> - 2017-05-18 15:20 +0200
      Re: [PATCH 3/3] livepatch: force transition process to finish Miroslav Benes <mbenes@suse.cz> - 2017-05-18 15:30 +0200
    Re: [PATCH 3/3] livepatch: force transition process to finish Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-23 19:30 +0200
      Re: [PATCH 3/3] livepatch: force transition process to finish Miroslav Benes <mbenes@suse.cz> - 2017-05-24 10:40 +0200
    Re: [PATCH 3/3] livepatch: force transition process to finish Petr Mladek <pmladek@suse.com> - 2017-05-24 15:10 +0200
      Re: [PATCH 3/3] livepatch: force transition process to finish Miroslav Benes <mbenes@suse.cz> - 2017-05-24 16:20 +0200
        Re: [PATCH 3/3] livepatch: force transition process to finish Petr Mladek <pmladek@suse.com> - 2017-05-24 17:20 +0200
  [PATCH 1/3] livepatch: Add force sysfs attribute Miroslav Benes <mbenes@suse.cz> - 2017-05-18 14:10 +0200
    Re: [PATCH 1/3] livepatch: Add force sysfs attribute Libor Pechacek <lpechacek@suse.com> - 2017-05-18 15:10 +0200
      Re: [PATCH 1/3] livepatch: Add force sysfs attribute Miroslav Benes <mbenes@suse.cz> - 2017-05-18 15:30 +0200

csiph-web