Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1644319

Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs

From Anatolij Gustschin <agust@denx.de>
Newsgroups linux.kernel
Subject Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs
Date 2017-05-18 13:50 +0200
Message-ID <tIs6l-1V1-13@gated-at.bofh.it> (permalink)
References <tIbRU-6Bk-11@gated-at.bofh.it> <tIbRV-6Bk-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

On Wed, 17 May 2017 20:23:41 +0200
Anatolij Gustschin agust@denx.de wrote:
...
>+	conf->spi = spi;
>+	conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);

we should use GPIOD_OUT_LOW flags here. nCONFIG is low active, so
setting logical high will enable the signal (drive the pin low),
resulting in configuration reset for already initialised FPGAs when
loading/reloading the module.

Thanks,

Anatolij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10 1/3] doc: dt: add altera-ps-spi binding document Anatolij Gustschin <agust@denx.de> - 2017-05-17 20:30 +0200
  [PATCH v10 3/3] ARM: dts: imx6q-evi: support cyclone-ps-spi Anatolij Gustschin <agust@denx.de> - 2017-05-17 20:30 +0200
  [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs Anatolij Gustschin <agust@denx.de> - 2017-05-17 20:30 +0200
    Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for  Altera FPGAs Anatolij Gustschin <agust@denx.de> - 2017-05-18 13:50 +0200
    Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for  Altera FPGAs Anatolij Gustschin <agust@denx.de> - 2017-05-18 23:00 +0200

csiph-web