Re: [PATCH v2] jbd2: preserve original nofs flag during journal restart

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] jbd2: preserve original nofs flag during journal restart
Date	2017-05-18 11:20 +0200
Message-ID	<tIpLb-8ip-3@gated-at.bofh.it> (permalink)
References	<tI93I-4Nh-19@gated-at.bofh.it> <tI9Q6-5lu-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 17-05-17 09:16:29, Tahsin Erdogan wrote:
[...]
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 9ee4832b6f8b..05c0323493fb 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -680,6 +680,8 @@ int jbd2__journal_restart(handle_t *handle, int nblocks, gfp_t gfp_mask)
> 
>  	rwsem_release(&journal->j_trans_commit_map, 1, _THIS_IP_);
>  	handle->h_buffer_credits = nblocks;
> +	/* Restore original nofs flag as jbd2_journal_stop() would do. */

I was thinking something more specific like
	/*
	 * Restore the original nofs context because the journal restart
	 * is basically the same thing as journal stop and start.
	 * start_this_handle will start a new nofs context.
	 */
> +	memalloc_nofs_restore(handle->saved_alloc_context);
>  	ret = start_this_handle(journal, handle, gfp_mask);
>  	return ret;
>  }
> -- 
> 2.13.0.303.g4ebf302169-goog
> 

-- 
Michal Hocko
SUSE Labs

Thread

[PATCH] jbd2: preserve original nofs flag during journal restart Tahsin Erdogan <tahsin@google.com> - 2017-05-17 14:40 +0200
  Re: [PATCH] jbd2: preserve original nofs flag during journal restart Jan Kara <jack@suse.cz> - 2017-05-17 16:10 +0200
  Re: [PATCH] jbd2: preserve original nofs flag during journal restart Michal Hocko <mhocko@kernel.org> - 2017-05-17 16:20 +0200
    Re: [PATCH] jbd2: preserve original nofs flag during journal restart Jan Kara <jack@suse.cz> - 2017-05-17 17:00 +0200
      Re: [PATCH] jbd2: preserve original nofs flag during journal restart Michal Hocko <mhocko@kernel.org> - 2017-05-17 17:30 +0200
        [PATCH v2] jbd2: preserve original nofs flag during journal restart Tahsin Erdogan <tahsin@google.com> - 2017-05-17 18:20 +0200
          Re: [PATCH v2] jbd2: preserve original nofs flag during journal  restart Michal Hocko <mhocko@kernel.org> - 2017-05-18 11:20 +0200
            Re: [PATCH v2] jbd2: preserve original nofs flag during journal  restart Jan Kara <jack@suse.cz> - 2017-05-18 11:40 +0200
              [PATCH v3] jbd2: preserve original nofs flag during journal restart Tahsin Erdogan <tahsin@google.com> - 2017-05-18 18:30 +0200
                Re: [PATCH v3] jbd2: preserve original nofs flag during journal  restart Theodore Ts'o <tytso@mit.edu> - 2017-05-20 06:20 +0200

csiph-web