Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1643874
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure |
| Date | 2017-05-18 08:50 +0200 |
| Message-ID | <tInq1-6iy-3@gated-at.bofh.it> (permalink) |
| References | <tIb5w-62C-23@gated-at.bofh.it> <tIboS-69O-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, May 17, 2017 at 07:50:31PM +0200, Florian Weimer wrote:
> On 05/17/2017 07:36 PM, Markus Trippelsdorf wrote:
> > Since:
> > commit cfafcd117da0216520568c195cb2f6cd1980c4bb
> > Author: Peter Zijlstra <peterz@infradead.org>
> > Date: Wed Mar 22 11:35:58 2017 +0100
> >
> > futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()
> >
> > glibc's nptl/tst-robustpi8 testcase fails:
> >
> > glibc-build % ./nptl/tst-robustpi8
> > tst-robustpi8: ../nptl/pthread_mutex_lock.c:424: __pthread_mutex_lock_full: Assertion `INTERNAL_SYSCALL_ERRNO (e, __err) != ESRCH || !robust' failed.
> >
> > pthread_mutex_lock.c:
> > 415 if (INTERNAL_SYSCALL_ERROR_P (e, __err)
> > 416 && (INTERNAL_SYSCALL_ERRNO (e, __err) == ESRCH
> > 417 || INTERNAL_SYSCALL_ERRNO (e, __err) == EDEADLK))
> > 418 {
> > 419 assert (INTERNAL_SYSCALL_ERRNO (e, __err) != EDEADLK
> > 420 || (kind != PTHREAD_MUTEX_ERRORCHECK_NP
> > 421 && kind != PTHREAD_MUTEX_RECURSIVE_NP));
> > 422 /* ESRCH can happen only for non-robust PI mutexes where
> > 423 the owner of the lock died. */
> > 424 assert (INTERNAL_SYSCALL_ERRNO (e, __err) != ESRCH || !robust);
> >
> > During bisection the commit above hangs the machine when I run the
> > testcase.
> >
> > See: https://sourceware.org/bugzilla/show_bug.cgi?id=21487
>
> Markus, could you confirm that it is chocking on the EAGAIN failure? Or
> is it something else?
>
> What is userspace supposed to do with the error code?
IIRC that -EAGAIN should not get to userspace. The kernel should retry
the lock operation. I'll go stare at it.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-05-17 19:40 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Florian Weimer <fweimer@redhat.com> - 2017-05-17 20:00 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-18 08:50 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-18 09:00 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-18 09:50 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-05-18 10:10 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-18 10:20 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Florian Weimer <fweimer@redhat.com> - 2017-05-18 10:20 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Florian Weimer <fweimer@redhat.com> - 2017-05-18 10:40 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-18 10:50 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Florian Weimer <fweimer@redhat.com> - 2017-05-18 10:50 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-18 13:50 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-18 14:40 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-19 17:50 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-19 18:10 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-05-19 19:40 +0200
[tip:locking/urgent] futex,rt_mutex: Fix rt_mutex_cleanup_proxy_lock() tip-bot for Peter Zijlstra <tipbot@zytor.com> - 2017-05-22 22:10 +0200
Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Peter Zijlstra <peterz@infradead.org> - 2017-05-18 10:40 +0200
csiph-web