Re: [RESEND PATCH] llist: Provide a safe version for llist_for_each

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH] llist: Provide a safe version for llist_for_each
Date	Thu, 18 May 2017 04:00:02 +0200
Message-ID	<tIiTo-2In-19@gated-at.bofh.it> (permalink)
References	<tG6MG-54r-13@gated-at.bofh.it>
X-Original-To	peterz@infradead.org
X-Original-Senderip	156.147.1.151
X-Original-Mailfrom	byungchul.park@lge.com
X-Original-Senderip	10.177.222.33
X-Original-Mailfrom	byungchul.park@lge.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, kernel-team@lge.com, viro@zeniv.linux.org.uk
X-Original-Date	Thu, 18 May 2017 10:58:11 +0900
X-Original-Message-ID	<20170518015811.GA28017@X58A-UD3R>
X-Original-References	<1494549416-10539-1-git-send-email-byungchul.park@lge.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1643734

Show key headers only | View raw

On Fri, May 12, 2017 at 09:36:56AM +0900, Byungchul Park wrote:
> Sometimes we have to dereference next field of llist node before entering
> loop becasue the node might be deleted or the next field might be
> modified within the loop. So this adds the safe version of llist_for_each,
> that is, llist_for_each_safe.

+cc viro@zeniv.linux.org.uk

> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
> ---
>  include/linux/llist.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/include/linux/llist.h b/include/linux/llist.h
> index fd4ca0b..b90c9f2 100644
> --- a/include/linux/llist.h
> +++ b/include/linux/llist.h
> @@ -105,6 +105,25 @@ static inline void init_llist_head(struct llist_head *list)
>  	for ((pos) = (node); pos; (pos) = (pos)->next)
>  
>  /**
> + * llist_for_each_safe - iterate over some deleted entries of a lock-less list
> + *			 safe against removal of list entry
> + * @pos:	the &struct llist_node to use as a loop cursor
> + * @n:		another &struct llist_node to use as temporary storage
> + * @node:	the first entry of deleted list entries
> + *
> + * In general, some entries of the lock-less list can be traversed
> + * safely only after being deleted from list, so start with an entry
> + * instead of list head.
> + *
> + * If being used on entries deleted from lock-less list directly, the
> + * traverse order is from the newest to the oldest added entry.  If
> + * you want to traverse from the oldest to the newest, you must
> + * reverse the order by yourself before traversing.
> + */
> +#define llist_for_each_safe(pos, n, node)			\
> +	for ((pos) = (node); (pos) && ((n) = (pos)->next, true); (pos) = (n))
> +
> +/**
>   * llist_for_each_entry - iterate over some deleted entries of lock-less list of given type
>   * @pos:	the type * to use as a loop cursor.
>   * @node:	the fist entry of deleted list entries.
> -- 
> 1.9.1

Thread

[RESEND PATCH] llist: Provide a safe version for llist_for_each Byungchul Park <byungchul.park@lge.com> - 2017-05-12 02:40 +0200
  [RESEND PATCH] mm: Don't reinvent the wheel but use existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-05-12 08:00 +0200
  Re: [RESEND PATCH] llist: Provide a safe version for llist_for_each Byungchul Park <byungchul.park@lge.com> - 2017-05-18 04:00 +0200
  Re: [RESEND PATCH] llist: Provide a safe version for llist_for_each Byungchul Park <byungchul.park@lge.com> - 2017-05-18 04:10 +0200
  Re: [RESEND PATCH] llist: Provide a safe version for llist_for_each Peter Zijlstra <peterz@infradead.org> - 2017-05-18 10:40 +0200
  [tip:sched/core] llist: Provide a safe version for llist_for_each() tip-bot for Byungchul Park <tipbot@zytor.com> - 2017-05-23 10:50 +0200

csiph-web