Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643727

答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

Show all headers | View raw

Hi Arnd,


On Fri, May 12, 2017 at 3:51 AM, Song Xiaowei <songxiaowei@hisilicon.com> wrote:
> From: songxiaowei <songxiaowei@hisilicon.com>

Looks good overall, just a few details:

Please fix your ~/.gitconfig to contain the same real name ("Song Xiaowei"
instead of "songxiaowei") that you use for sending the emails.

[Xiaowei Song]  I'll fix this issue and update the patch.

> +
> +static int kirin_pcie_phy_init(struct kirin_pcie *kirin_pcie) {
...
> +       reg_val = kirin_apb_phy_readl(kirin_pcie, 0x400);
> +       while (reg_val & pipe_clk_stable) {
> +               udelay(100);
> +               if (time == 0) {
> +                       dev_err(kirin_pcie->pci->dev, "PIPE clk is not stable\n");
> +                       return -EINVAL;
> +               }
> +               time--;
> +               reg_val = kirin_apb_phy_readl(kirin_pcie, 0x400);
> +       }

If this is not called with interrupts disabled, please use a sleeping function (e.g. msleep(1)) as the delay and compare against ktime_before() to see how much total time has expired when waiting for a timeout, instead of using a counter.

[Xiaowei Song] This issue was fixed in the patch sent at 2017-5-15, and I'll send it again.

> diff --git a/drivers/pci/dwc/pcie-kirin.h 
> b/drivers/pci/dwc/pcie-kirin.h new file mode 100644 index 
> 000000000000..ad9a3b427298
> --- /dev/null
> +++ b/drivers/pci/dwc/pcie-kirin.h
> @@ -0,0 +1,79 @@
> +/*
> + * PCIe host controller driver for Kirin 960 SoCs
> + *
> + * Copyright (C) 2015 Huawei Electronics Co., Ltd.
> + *             http://www.huawei.com
> + *
> + * Author: Xiaowei Song <songxiaowei@huawei.com>

The header is only used in one .c file, so just remove it and add the contents to that file.

[songxiaowei] In new patch the header file was deleted,


Thanks a lot.

Best regard,
Xiaowei.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC Song Xiaowei <songxiaowei@hisilicon.com> - 2017-05-12 04:00 +0200
  [PATCH 2/2] defconfig: PCI: Enable  Kirin PCIe defconfig Song Xiaowei <songxiaowei@hisilicon.com> - 2017-05-12 04:10 +0200
  Re: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin  SoC Niklas Cassel <niklas.cassel@axis.com> - 2017-05-12 10:10 +0200
    答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC songxiaowei <songxiaowei@hisilicon.com> - 2017-05-12 11:20 +0200
  Re: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC Arnd Bergmann <arnd@arndb.de> - 2017-05-17 22:30 +0200
    答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC songxiaowei <songxiaowei@hisilicon.com> - 2017-05-18 04:00 +0200
      Re: 答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC Guodong Xu <guodong.xu@linaro.org> - 2017-05-18 08:30 +0200
        Re: 答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC Niklas Cassel <niklas.cassel@axis.com> - 2017-05-18 11:00 +0200
          答复: 答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC songxiaowei <songxiaowei@hisilicon.com> - 2017-05-18 11:20 +0200
    答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC songxiaowei <songxiaowei@hisilicon.com> - 2017-05-18 09:40 +0200

csiph-web