Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1643710

[PATCH] perf annotate: process tracing data in pipe mode

From David Carrillo-Cisneros <davidcc@google.com>
Newsgroups linux.kernel
Subject [PATCH] perf annotate: process tracing data in pipe mode
Date 2017-05-18 02:20 +0200
Message-ID <tIhkB-1NU-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


perf annotate was missing the handler for tracing data records.

Prior to this patch we obtained "unhandled" records when piping
trace events to perf annotate (using -D option to show the
dump_printf messages in process_event_synth_tracing_data_stub):

  $ perf record -o - -e block:bio_free sleep 2 | perf annotate -D --stdio
  ...
  0x78 [0xc]: PERF_RECORD_TRACING_DATA: unhandled!
  ...

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
 tools/perf/builtin-annotate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 7a5dc7e5c577..ce44edc30c71 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -397,6 +397,7 @@ int cmd_annotate(int argc, const char **argv)
 			.namespaces = perf_event__process_namespaces,
 			.attr	= perf_event__process_attr,
 			.build_id = perf_event__process_build_id,
+			.tracing_data   = perf_event__process_tracing_data,
 			.ordered_events = true,
 			.ordering_requires_timestamps = true,
 		},
-- 
2.13.0.303.g4ebf302169-goog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] perf annotate: process tracing data in pipe mode David Carrillo-Cisneros <davidcc@google.com> - 2017-05-18 02:20 +0200

csiph-web