Re: Build warning 'uninitialized variable' in fs/overlayfs

From	Amir Goldstein <amir73il@gmail.com>
Newsgroups	linux.kernel
Subject	Re: Build warning 'uninitialized variable' in fs/overlayfs
Date	2017-05-18 00:20 +0200
Message-ID	<tIfsu-AE-1@gated-at.bofh.it> (permalink)
References	<tIfsu-AE-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 17, 2017 at 11:26 PM, Yury Norov <ynorov@caviumnetworks.com> wrote:
> Hi Amir,
>
> (Sorry for new email, but I cannot find your patch in my mailbox,
> though found it in next-20170517)
>
> Your patch 02cac3227a282 (ovl: mark upper dir with type origin entries
> "impure") makes gcc warn on uninitialized variables in my arm64 build:
> fs/overlayfs/dir.c: In function ‘ovl_rename’:
> fs/overlayfs/dir.c:1060:2: warning: ‘newdentry’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> dput(newdentry);
> ^~~~~~~~~~~~~~~
> fs/overlayfs/dir.c:1062:2: warning: ‘olddentry’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> dput(olddentry);
> ^~~~~~~~~~~~~~~
>
> The patch below fixes warnings for me. But I'm not familiar to the
> subsystem and so not sure that the fix is correct.
>
It's not. Should be goto out_revert_creds;

Already sent a fix for that.
Thanks!

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: Build warning 'uninitialized variable' in fs/overlayfs Amir Goldstein <amir73il@gmail.com> - 2017-05-18 00:20 +0200

csiph-web