Re: [RFC PATCH v2 10/17] cgroup: Make debug cgroup support v2 and thread mode

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2 10/17] cgroup: Make debug cgroup support v2 and thread mode
Date	2017-05-17 23:50 +0200
Message-ID	<tIeZr-8x-9@gated-at.bofh.it> (permalink)
References	<tHoo9-lZ-3@gated-at.bofh.it> <tHooa-lZ-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Mon, May 15, 2017 at 09:34:09AM -0400, Waiman Long wrote:
> Besides supporting cgroup v2 and thread mode, the following changes
> are also made:
>  1) current_* cgroup files now resides only at the root as we don't
>     need duplicated files of the same function all over the cgroup
>     hierarchy.
>  2) The cgroup_css_links_read() function is modified to report
>     the number of tasks that are skipped because of overflow.
>  3) The relationship between proc_cset and threaded_csets are displayed.
>  4) The number of extra unaccounted references are displayed.
>  5) The status of being a thread root or threaded cgroup is displayed.
>  6) The current_css_set_read() function now prints out the addresses of
>     the css'es associated with the current css_set.
>  7) A new cgroup_subsys_states file is added to display the css objects
>     associated with a cgroup.
>  8) A new cgroup_masks file is added to display the various controller
>     bit masks in the cgroup.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

As noted before, please make it clear that this is a debug feature and
not expected to be stable.  Also, I don't see why this and the
previous two patches are in this series.  Can you please split these
out to a separate patchset?

Thanks.

-- 
tejun

Thread

[RFC PATCH v2 10/17] cgroup: Make debug cgroup support v2 and thread mode Waiman Long <longman@redhat.com> - 2017-05-15 15:40 +0200
  Re: [RFC PATCH v2 10/17] cgroup: Make debug cgroup support v2 and  thread mode Tejun Heo <tj@kernel.org> - 2017-05-17 23:50 +0200
    Re: [RFC PATCH v2 10/17] cgroup: Make debug cgroup support v2 and  thread mode Waiman Long <longman@redhat.com> - 2017-05-18 18:00 +0200

csiph-web