Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1643619

Re: [RFC PATCH v2 07/17] cgroup: Prevent kill_css() from being called more than once

From Waiman Long <longman@redhat.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v2 07/17] cgroup: Prevent kill_css() from being called more than once
Date 2017-05-17 22:30 +0200
Message-ID <tIdK1-7Nc-5@gated-at.bofh.it> (permalink)
References <tHoo9-lZ-3@gated-at.bofh.it> <tHoob-lZ-51@gated-at.bofh.it> <tIcNY-7cM-13@gated-at.bofh.it>
Organization Red Hat

Show all headers | View raw


On 05/17/2017 03:23 PM, Tejun Heo wrote:
> Hello,
>
> On Mon, May 15, 2017 at 09:34:06AM -0400, Waiman Long wrote:
>> The kill_css() function may be called more than once under the condition
>> that the css was killed but not physically removed yet followed by the
>> removal of the cgroup that is hosting the css. This patch prevents any
>> harmm from being done when that happens.
>>
>> Signed-off-by: Waiman Long <longman@redhat.com>
> So, this is a bug fix which isn't really related to this patchset.
> I'm applying it to cgroup/for-4.12-fixes w/ stable cc'd.
>
> Thanks.
>
Actually, this bug can be easily triggered with the resource domain
patch later in the series. I guess it can also happen in the current
code base, but I don't have a test that can reproduce it.

Regards,
Longman

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH v2 07/17] cgroup: Prevent kill_css() from being called more than once Waiman Long <longman@redhat.com> - 2017-05-15 15:40 +0200
  Re: [RFC PATCH v2 07/17] cgroup: Prevent kill_css() from being  called more than once Tejun Heo <tj@kernel.org> - 2017-05-17 21:30 +0200
    Re: [RFC PATCH v2 07/17] cgroup: Prevent kill_css() from being called  more than once Waiman Long <longman@redhat.com> - 2017-05-17 22:30 +0200
      Re: [RFC PATCH v2 07/17] cgroup: Prevent kill_css() from being  called more than once Tejun Heo <tj@kernel.org> - 2017-05-17 23:40 +0200

csiph-web