[PATCH] CIFS: check if pages is null rather than bv for a failed allocation

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] CIFS: check if pages is null rather than bv for a failed allocation
Date	2017-05-17 20:30 +0200
Message-ID	<tIbRU-6Bk-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

pages is being allocated however a null check on bv is being used
to see if the allocation failed. Fix this by checking if pages is
null.

Detected by CoverityScan, CID#1432974 ("Logically dead code")

Fixes: ccf7f4088af2dd ("CIFS: Add asynchronous context to support kernel AIO")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/cifs/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index b08531977daa..3b147dc6af63 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -810,7 +810,7 @@ setup_aio_ctx_iter(struct cifs_aio_ctx *ctx, struct iov_iter *iter, int rw)
 
 	if (!pages) {
 		pages = vmalloc(max_pages * sizeof(struct page *));
-		if (!bv) {
+		if (!pages) {
 			kvfree(bv);
 			return -ENOMEM;
 		}
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] CIFS: check if pages is null rather than bv for a failed allocation Colin King <colin.king@canonical.com> - 2017-05-17 20:30 +0200
  Re: [PATCH] CIFS: check if pages is null rather than bv for a failed allocation Pavel Shilovsky <piastryyy@gmail.com> - 2017-05-17 22:10 +0200

csiph-web