Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643505

[PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies

Show all headers | View raw

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not
enabled (seen on x86_64).

drivers/built-in.o: In function `sba_prep_dma_pq_req':
(.text+0x16132): undefined reference to `raid6_gflog'
drivers/built-in.o: In function `sba_prep_dma_pq_single_req':
(.text+0x162f4): undefined reference to `raid6_gflog'

This driver needs RAID6_PQ and MAILBOX (from inspection) independent of
ARM64 or COMPILE_TEST.

However, RAID6_PQ is not defined in any Kconfig file, although it is
used in several of them. :(

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Anup Patel <anup.patel@broadcom.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20170517.orig/drivers/dma/Kconfig
+++ linux-next-20170517/drivers/dma/Kconfig
@@ -101,7 +101,8 @@ config AXI_DMAC
 
 config BCM_SBA_RAID
 	tristate "Broadcom SBA RAID engine support"
-	depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST
+	depends on ARM64 || COMPILE_TEST
+	depends on MAILBOX && RAID6_PQ
 	select DMA_ENGINE
 	select DMA_ENGINE_RAID
 	select ASYNC_TX_DISABLE_XOR_VAL_DMA

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies Randy Dunlap <rdunlap@infradead.org> - 2017-05-17 18:50 +0200
  Re: [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-17 20:20 +0200
  Re: [PATCH -next] dma: bcm-sba-raid: fix build errors and  dependencies Vinod Koul <vinod.koul@intel.com> - 2017-05-19 05:50 +0200

csiph-web