[PATCH] ezusb: Delete an error message for a failed memory allocation in ezusb_writememory()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH] ezusb: Delete an error message for a failed memory allocation in ezusb_writememory()
Date	2017-05-19 22:40 +0200
Message-ID	<tIWQO-7ue-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 19 May 2017 22:30:21 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/usb/misc/ezusb.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/misc/ezusb.c b/drivers/usb/misc/ezusb.c
index 837208f14f86..6d5e468dc897 100644
--- a/drivers/usb/misc/ezusb.c
+++ b/drivers/usb/misc/ezusb.c
@@ -41,11 +41,9 @@ static int ezusb_writememory(struct usb_device *dev, int address,
 		return -ENODEV;
 
 	transfer_buffer = kmemdup(data, length, GFP_KERNEL);
-	if (!transfer_buffer) {
-		dev_err(&dev->dev, "%s - kmalloc(%d) failed.\n",
-							__func__, length);
+	if (!transfer_buffer)
 		return -ENOMEM;
-	}
+
 	result = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), request,
 				 USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
 				 address, 0, transfer_buffer, length, 3000);
-- 
2.13.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] ezusb: Delete an error message for a failed memory allocation  in ezusb_writememory() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-19 22:40 +0200

csiph-web