Re: [PATCH] selinux: Mark array 'labeling_behaviors' as __maybe_unused

From	Matthias Kaehlcke <mka@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] selinux: Mark array 'labeling_behaviors' as __maybe_unused
Date	2017-05-19 19:00 +0200
Message-ID	<tITpU-4T3-21@gated-at.bofh.it> (permalink)
References	<tIyY9-6Wp-1@gated-at.bofh.it> <tIRHr-3XA-9@gated-at.bofh.it> <tISka-4bg-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

El Fri, May 19, 2017 at 11:45:19AM -0400 Stephen Smalley ha dit:

> On Fri, 2017-05-19 at 11:09 -0400, Paul Moore wrote:
> > On Thu, May 18, 2017 at 3:07 PM, Matthias Kaehlcke <mka@chromium.org>
> > wrote:
> > > The array is only referenced in an ARRAY_SIZE() statement. Adding
> > > the
> > > attribute fixes the following warning when building with clang:
> > > 
> > > security/selinux/hooks.c:338:20: error: variable
> > > 'labeling_behaviors'
> > >     is not needed and will not be emitted
> > >     [-Werror,-Wunneeded-internal-declaration]
> > > 
> > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > > ---
> > >  security/selinux/hooks.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > The fact that we only reference labeling_behaviors in one spot, and
> > even then we only use it as a parameter to ARRAY_SIZE(), makes me
> > believe we may be able to get rid of labeling_behaviors and use
> > SECURITY_FS_USE_MAX in its place.
> > 
> > Anyone working on any patches which make use of labeling_behaviors?
> 
> I think you could just remove both the array and the code that
> referenced it; it only made sense before commit
> 2088d60e3b2f53d0c9590a0202eeff85b288b1eb.  We already check that the
> policy doesn't contain any behavior > SECURITY_FS_USE_MAX during policy
> load, so this cannot occur (modulo memory corruption), and it was only
> there to make sure we didn't try to dereference off the end of the
> array prior to the aforementioned commit.

Thanks for your comments.

I will send out a patch that removes the array shortly.

Matthias

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] selinux: Mark array 'labeling_behaviors' as __maybe_unused Matthias Kaehlcke <mka@chromium.org> - 2017-05-18 21:10 +0200
  Re: [PATCH] selinux: Mark array 'labeling_behaviors' as __maybe_unused Paul Moore <paul@paul-moore.com> - 2017-05-19 17:10 +0200
    Re: [PATCH] selinux: Mark array 'labeling_behaviors' as  __maybe_unused Stephen Smalley <sds@tycho.nsa.gov> - 2017-05-19 17:50 +0200
      Re: [PATCH] selinux: Mark array 'labeling_behaviors' as  __maybe_unused Matthias Kaehlcke <mka@chromium.org> - 2017-05-19 19:00 +0200

csiph-web