Re: [PATCH 5/6] gpio: mvebu: Add support for the Armada 7K/8K SoCs

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] gpio: mvebu: Add support for the Armada 7K/8K SoCs
Date	Fri, 19 May 2017 18:30:01 +0200
Message-ID	<tISWR-4IO-3@gated-at.bofh.it> (permalink)
References	<tISDw-4BS-23@gated-at.bofh.it> <tISDw-4BS-21@gated-at.bofh.it> <tISWR-4IO-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=M69cqN8F/z9Ef5XoZKPsDu+KEyTyvvjY/wn09anBPW4=; b=d4SwaaQzd0Y7DCBqV775v1Dk0dwjZzpzV5g6NVwf3WVgAq1v/BtHrW2JDmhYSgw7xnvoEe+l1TiV1laS4LoQD6gyz3oNuGgeTLuKBDMmaTSr4eBkd0uTrFAcO+NAy1fI5SNFN8HroZ14gg4xxuDIh2S4x3MB++l38xQXm1Ayk3E=;
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, Alexandre Courbot <gnurou@gmail.com>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Linus Walleij <linus.walleij@linaro.org>, Omri Itach <omrii@marvell.com>, linux-kernel@vger.kernel.org, Nadav Haklai <nadavh@marvell.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Neta Zur Hershkovits <neta@marvell.com>, Kostya Porotchkin <kostap@marvell.com>, Shadi Ammouri <shadi@marvell.com>, Marcin Wojtas <mw@semihalf.com>, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
X-Original-Date	Fri, 19 May 2017 17:27:36 +0100
X-Original-Message-ID	<20170519162736.GU22219@n2100.armlinux.org.uk>
X-Original-References	<cover.e10718b9c0f9fdd07327ae14e213be8da5b1f7ef.1495210061.git-series.gregory.clement@free-electrons.com> <54efbdfb0a9800b2c72c6fa1d945c87182b242b4.1495210061.git-series.gregory.clement@free-electrons.com> <20170519162410.GT22219@n2100.armlinux.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1645743

Show key headers only | View raw

On Fri, May 19, 2017 at 05:24:10PM +0100, Russell King - ARM Linux wrote:
> On Fri, May 19, 2017 at 06:09:24PM +0200, Gregory CLEMENT wrote:
> > The Armada 7K and 8K SoCs use the same gpio controller as most of the
> > other mvebu SoCs. However, the main difference is that the GPIO
> > controller is part of a bigger system controller, and a syscon is used to
> > control the overall system controller. Therefore, the driver needs to be
> > adjusted to retrieve the regmap of the syscon to access registers, and
> > account for the fact that registers are located at a certain offset
> > within the regmap.
> > 
> > This commit add the support of the syscon and introduce a new variant for
> > this case.
> 
> Do you really need all this complexity of merging what seems to be two
> GPIO devices into one for DT purposes?  The device itself appears to be
> two instances of the orion-gpio controller, one at 0x100 into the
> system controller and a second one at 0x140.
> 
> If you instantiate two orion-gpio controllers, then you don't need to
> add the "mvchip->offset" stuff.
> 
> I'd also say that it was the more correct approach, rather than adding
> more complexity to GPIO drivers to support whatever incarnation comes
> next.

Hmm, in fact, mvebu->offset always appears to be zero in this driver,
so I think the changes that add this member are entirely rendundant to
the function of this patch.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Thread

[PATCH 5/6] gpio: mvebu: Add support for the Armada 7K/8K SoCs Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-05-19 18:10 +0200
  Re: [PATCH 5/6] gpio: mvebu: Add support for the Armada 7K/8K SoCs Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-19 18:30 +0200
    Re: [PATCH 5/6] gpio: mvebu: Add support for the Armada 7K/8K SoCs Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-19 18:30 +0200
      Re: [PATCH 5/6] gpio: mvebu: Add support for the Armada 7K/8K SoCs Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-19 19:10 +0200

csiph-web