Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645651

Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe

From Jens Axboe <axboe@kernel.dk>
Newsgroups linux.kernel
Subject Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe
Date 2017-05-19 16:40 +0200
Message-ID <tIRep-3xO-7@gated-at.bofh.it> (permalink)
References <tILC2-7Vr-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 05/19/2017 02:39 AM, Paolo Valente wrote:
> @@ -692,8 +725,7 @@ void bfq_pd_offline(struct blkg_policy_data *pd)
>  		/*
>  		 * The idle tree may still contain bfq_queues belonging
>  		 * to exited task because they never migrated to a different
> -		 * cgroup from the one being destroyed now.  No one else
> -		 * can access them so it's safe to act without any lock.
> ++                * cgroup from the one being destroyed now.
>  		 */
>  		bfq_flush_idle_tree(st);
>  

Looks like an extra '+' snuck into that hunk.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH BUGFIX] block, bfq: access and cache blkg data only when safe Paolo Valente <paolo.valente@linaro.org> - 2017-05-19 10:40 +0200
  Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when  safe Jens Axboe <axboe@kernel.dk> - 2017-05-19 16:40 +0200
    Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe Paolo Valente <paolo.valente@linaro.org> - 2017-05-22 22:30 +0200
  Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when  safe Tejun Heo <tj@kernel.org> - 2017-05-19 17:00 +0200
    Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe Paolo Valente <paolo.valente@linaro.org> - 2017-05-20 09:30 +0200
      Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when  safe Tejun Heo <tj@kernel.org> - 2017-05-23 22:50 +0200
        Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe Paolo Valente <paolo.valente@linaro.org> - 2017-05-24 14:00 +0200
          Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe Paolo Valente <paolo.valente@linaro.org> - 2017-05-24 16:30 +0200
          Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when  safe Tejun Heo <tj@kernel.org> - 2017-05-24 17:00 +0200
            Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when  safe Tejun Heo <tj@kernel.org> - 2017-05-24 18:50 +0200
            Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe Paolo Valente <paolo.valente@linaro.org> - 2017-05-24 18:50 +0200

csiph-web