Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1645615
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors |
| Date | 2017-05-19 15:50 +0200 |
| Message-ID | <tIQs2-2Qk-15@gated-at.bofh.it> (permalink) |
| References | <tIH5n-4Bf-1@gated-at.bofh.it> <tIIXv-60O-1@gated-at.bofh.it> <tIN18-GC-21@gated-at.bofh.it> <tIPmh-2aO-3@gated-at.bofh.it> <tIPvY-2eo-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 19 May 2017 14:46:25 +0200
Christoph Hellwig <hch@lst.de> wrote:
> On Fri, May 19, 2017 at 08:37:21AM -0400, Steven Rostedt wrote:
> > ktest config bisect ended with:
> >
> > ***************************************
> > Found bad config: CONFIG_PCI_MSI
> > ***************************************
>
> Oh, that's interesting. I think there's been a bug in the !CONFIG_PCI_MSI
> fallback for pci_alloc_irq_vectors since the very beginning. And it
> didn't matter for any driver so far, but xhci has a very odd way
> to set MSI(-X) vs legacy interrupts.
>
> Can you try the patch below?
Works. Thanks!
Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
>
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 33c2b0b77429..5a7fd3b6a7b9 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1342,7 +1342,7 @@ pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
> unsigned int max_vecs, unsigned int flags,
> const struct irq_affinity *aff_desc)
> {
> - if (min_vecs > 1)
> + if (min_vecs > 1 || !(flags & PCI_IRQ_LEGACY))
> return -EINVAL;
> return 1;
> }
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-19 07:50 +0200
Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors Steven Rostedt <rostedt@goodmis.org> - 2017-05-19 12:10 +0200
Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors Steven Rostedt <rostedt@goodmis.org> - 2017-05-19 14:40 +0200
Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors Christoph Hellwig <hch@lst.de> - 2017-05-19 14:50 +0200
Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors Steven Rostedt <rostedt@goodmis.org> - 2017-05-19 15:50 +0200
Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors Christoph Hellwig <hch@lst.de> - 2017-05-20 19:00 +0200
Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-20 19:00 +0200
csiph-web