Re: [PATCH 4/4] KVM: x86: prevent uninitialized variable warning in check_svme()

From	David Hildenbrand <david@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] KVM: x86: prevent uninitialized variable warning in check_svme()
Date	2017-05-19 15:40 +0200
Message-ID	<tIQim-2MD-13@gated-at.bofh.it> (permalink)
References	<tIxz3-5R2-3@gated-at.bofh.it> <tIxz3-5R2-1@gated-at.bofh.it>
Organization	Red Hat GmbH

Show all headers | View raw

On 18.05.2017 19:37, Radim Krčmář wrote:
> get_msr() of MSR_EFER is currently always going to succeed, but static
> checker doesn't see that far.
> 
> Don't complicate stuff and just use 0 for the fallback -- it means that
> the feature is not present.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
>  arch/x86/kvm/emulate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index c25cfaf584e7..0816ab2e8adc 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -4173,7 +4173,7 @@ static int check_dr_write(struct x86_emulate_ctxt *ctxt)
>  
>  static int check_svme(struct x86_emulate_ctxt *ctxt)
>  {
> -	u64 efer;
> +	u64 efer = 0;
>  
>  	ctxt->ops->get_msr(ctxt, MSR_EFER, &efer);
>  
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] KVM: x86: prevent uninitialized variable warning in check_svme() Radim Krčmář <rkrcmar@redhat.com> - 2017-05-18 19:40 +0200
  Re: [PATCH 4/4] KVM: x86: prevent uninitialized variable warning in  check_svme() David Hildenbrand <david@redhat.com> - 2017-05-19 15:40 +0200

csiph-web