Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645591

Re: [PATCH 05/24] thunderbolt: Rework capability handling

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 05/24] thunderbolt: Rework capability handling
Date 2017-05-19 15:20 +0200
Message-ID <tIPYZ-2G4-1@gated-at.bofh.it> (permalink)
References <tIuKR-3YK-5@gated-at.bofh.it> <tIuUy-44c-1@gated-at.bofh.it> <tIwD0-5eS-11@gated-at.bofh.it> <tILiH-7O7-47@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, May 19, 2017 at 11:12 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Thu, May 18, 2017 at 07:38:29PM +0300, Andy Shevchenko wrote:
>> On Thu, May 18, 2017 at 5:38 PM, Mika Westerberg
>> <mika.westerberg@linux.intel.com> wrote:

>> One nit here.

>> Both has quite similar bodies.
>> Wouldn't be nice to split out a helper which takes initial offset and
>> type as parameters?
>
> The whole point of this rework was to separate port vs. switch
> capability to follow how the hardware is organized instead of having one
> more complex function handling everything :)
>
> Sure, I can merge them back together but IMHO it will be not that
> readable anymore.

Up to you. I'm fine with either.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 05/24] thunderbolt: Rework capability handling Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-18 16:50 +0200
  Re: [PATCH 05/24] thunderbolt: Rework capability handling Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 18:40 +0200
    Re: [PATCH 05/24] thunderbolt: Rework capability handling Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-19 10:20 +0200
      Re: [PATCH 05/24] thunderbolt: Rework capability handling Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-19 15:20 +0200
  Re: [PATCH 05/24] thunderbolt: Rework capability handling Andreas Noever <andreas.noever@gmail.com> - 2017-05-21 21:20 +0200
    Re: [PATCH 05/24] thunderbolt: Rework capability handling Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-22 11:50 +0200
      RE: [PATCH 05/24] thunderbolt: Rework capability handling "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2017-05-22 12:00 +0200

csiph-web