Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g

From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g
Date	2017-05-19 13:30 +0200
Message-ID	<tIOgy-1r7-15@gated-at.bofh.it> (permalink)
References	<tIqnT-qA-3@gated-at.bofh.it> <tIqnT-qA-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> +/**
> + * Ioctl to query plane info or create dma-buf
> + */
> +#define INTEL_VGPU_QUERY_DMABUF		0
> +#define INTEL_VGPU_GENERATE_DMABUF	1

This should use _IO* #defines.

> +struct intel_vgpu_dmabuf {
> +	__u32 plane_id;
> +	/* out */
> +	__u32 fd;
> +	__u32 drm_format;
> +	__u32 width;
> +	__u32 height;
> +	__u32 stride;
> +	__u32 start;
> +	__u32 x_pos;
> +	__u32 y_pos;
> +	__u32 size;
> +	__u32 tiled;

I'd suggest to drop tiled, and add drm_format_mod (for
fourcc_mod_code()) instead.

You can also move intel_vgpu_plane_info to this place and just use it as
sub-struct for intel_vgpu_dmabuf.

cheers,
  Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-18 12:00 +0200
  Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-18 12:30 +0200
  Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g Gerd Hoffmann <kraxel@redhat.com> - 2017-05-19 13:30 +0200

csiph-web