Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645525

RE: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

Show all headers | View raw

From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-owner@vger.kernel.org] On Behalf Of Jim Baxter
> Sent: 16 May 2017 18:41
> 
> The CDC-NCM driver can require large amounts of memory to create
> skb's and this can be a problem when the memory becomes fragmented.
> 
> This especially affects embedded systems that have constrained
> resources but wish to maximise the throughput of CDC-NCM with 16KiB
> NTB's.

Why is this driver copying multiple tx messages into a single skb.
Surely there are better ways to do this??

I think it is generating a 'multi-ethernet frame' URB with an
overall header for each URB and a header for each ethernet frame.

Given that the USB stack allows multiple concurrent transmits I'm
surprised that batching large ethernet frames makes much difference.

Also the USB target can't actually tell when URB that contain
multiples of the USB packet size end.
So it is possible to send a single NTB as multiple URB.
Of course, the usb_net might have other ideas.

	David

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low Jim Baxter <jim_baxter@mentor.com> - 2017-05-16 19:50 +0200
  Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low Bjørn Mork <bjorn@mork.no> - 2017-05-16 20:30 +0200
    Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low Oliver Neukum <oneukum@suse.com> - 2017-05-17 09:50 +0200
      Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low "Baxter, Jim" <jim_baxter@mentor.com> - 2017-05-17 13:00 +0200
    Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel  memory low David Miller <davem@davemloft.net> - 2017-05-17 20:20 +0200
      Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low Oliver Neukum <oneukum@suse.com> - 2017-05-18 12:10 +0200
      Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low "Baxter, Jim" <jim_baxter@mentor.com> - 2017-05-22 17:50 +0200
        Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel  memory low David Miller <davem@davemloft.net> - 2017-05-22 18:00 +0200
          Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low Oliver Neukum <oneukum@suse.com> - 2017-05-23 10:50 +0200
            Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel  memory low David Miller <davem@davemloft.net> - 2017-05-23 17:30 +0200
              Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low "Baxter, Jim" <jim_baxter@mentor.com> - 2017-05-23 21:10 +0200
  RE: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low David Laight <David.Laight@ACULAB.COM> - 2017-05-19 13:20 +0200
    Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low Bjørn Mork <bjorn@mork.no> - 2017-05-19 16:00 +0200
      RE: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low David Laight <David.Laight@ACULAB.COM> - 2017-05-19 16:50 +0200
        Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory  low Oliver Neukum <oneukum@suse.com> - 2017-05-22 15:30 +0200

csiph-web