Re: [PATCH 07/24] thunderbolt: Convert switch to a device

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/24] thunderbolt: Convert switch to a device
Date	2017-05-19 10:30 +0200
Message-ID	<tILsl-7S6-3@gated-at.bofh.it> (permalink)
References	<tIuKR-3YK-5@gated-at.bofh.it> <tIuUy-44c-3@gated-at.bofh.it> <tIwMF-5iy-3@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Thu, May 18, 2017 at 07:49:21PM +0300, Andy Shevchenko wrote:
> On Thu, May 18, 2017 at 5:38 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > Thunderbolt domain consists of switches that are connected to each
> > other, forming a bus. This will convert each switch into a real Linux
> > device structure and adds them to the domain. The advantage here is
> > that we get all the goodies from the driver core, like reference
> > counting and sysfs hierarchy for free.
> >
> > Also expose device identification information to the userspace via new
> > sysfs attributes.
> >
> > In order to support internal connection manager (ICM) we separate switch
> > configuration into its own function (tb_switch_configure()) which is
> > only called by the existing native connection manager implementation
> > used on Macs.
> >
> 
> Couple of nits below.
> 
> > +
> > +       return sw;
> > +err:
> 
> Perhaps
> err_free_sw_ports:
> ?

Works for me :)

> > +       kfree(sw->ports);
> > +       kfree(sw);
> > +       return NULL;
> > +}
> 
> > +       /* upload configuration */
> > +       ret = tb_sw_write(sw, 1 + (u32 *) &sw->config, TB_CFG_SWITCH, 1, 3);
> 
> Extra space before &.

This comes from the original code but I'll change it.

> > +       if (ret)
> > +               return ret;
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Thread

[PATCH 07/24] thunderbolt: Convert switch to a device Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-18 16:50 +0200
  Re: [PATCH 07/24] thunderbolt: Convert switch to a device Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 18:50 +0200
    Re: [PATCH 07/24] thunderbolt: Convert switch to a device Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-19 10:30 +0200
  Re: [PATCH 07/24] thunderbolt: Convert switch to a device Lukas Wunner <lukas@wunner.de> - 2017-05-24 13:10 +0200
    Re: [PATCH 07/24] thunderbolt: Convert switch to a device Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-24 13:50 +0200
      Re: [PATCH 07/24] thunderbolt: Convert switch to a device Lukas Wunner <lukas@wunner.de> - 2017-05-24 16:00 +0200

csiph-web