Re: [v2] mwifiex: pcie: de-duplicate buffer allocation code

From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [v2] mwifiex: pcie: de-duplicate buffer allocation code
Date	2017-05-19 08:10 +0200
Message-ID	<tIJgR-6wx-5@gated-at.bofh.it> (permalink)
References	<tIwD0-5eS-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Brian Norris <briannorris@chromium.org> wrote:
> This code was duplicated as part of the PCIe FLR code added to this
> driver. Let's de-duplicate it to:
> 
>  * make things easier to read (mwifiex_pcie_free_buffers() now has a
>    corresponding mwifiex_pcie_alloc_buffers())
>  * reduce likelihood of bugs
>  * make error logging equally verbose
>  * save lines of code!
> 
> Also drop some of the commentary that isn't really needed.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Patch applied to wireless-drivers-next.git, thanks.

d41bf5c1c0ed mwifiex: pcie: de-duplicate buffer allocation code

-- 
https://patchwork.kernel.org/patch/9734777/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] mwifiex: pcie: de-duplicate buffer allocation code Brian Norris <briannorris@chromium.org> - 2017-05-18 18:40 +0200
  Re: [v2] mwifiex: pcie: de-duplicate buffer allocation code Kalle Valo <kvalo@codeaurora.org> - 2017-05-19 08:10 +0200

csiph-web