Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645148

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

Show all headers | View raw

On Thu, May 18, 2017 at 08:56:32PM -0500, Josh Poimboeuf wrote:
> > 
> > Hmm, it looks like a number of other algorithms in arch/x86/crypto/ use %rbp (or
> > %ebp), e.g. blowfish, camellia, cast5, and aes-i586.  Presumably they have the
> > same problem.  I'm a little confused: do these all need to be fixed, and
> > when/why did this start being considered broken?
> 
> This warning was only recently added, with the goal of flushing out
> these types of issues with hand-coded asm to make frame pointer based
> stack traces more reliable.  I can take a look at fixing the rest of
> them if you want.
> 

Okay.  I'm worried you might run into one that is difficult to fix due to lack
of spare registers.  But if you're interested in looking into it, please go
ahead.  Thanks!

Eric

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: x86/aes - Don't use %rbp as temporary register Eric Biggers <ebiggers3@gmail.com> - 2017-05-17 06:10 +0200
  Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-17 22:50 +0200
    Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register Eric Biggers <ebiggers3@gmail.com> - 2017-05-18 00:30 +0200
      Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-19 04:00 +0200
        Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register Eric Biggers <ebiggers3@gmail.com> - 2017-05-19 05:00 +0200
  Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register Herbert Xu <herbert@gondor.apana.org.au> - 2017-05-23 07:10 +0200

csiph-web