[PATCH 6/6] kmod: use simplified rate limit printk

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 6/6] kmod: use simplified rate limit printk
Date	2017-05-19 05:30 +0200
Message-ID	<tIGM1-4u0-7@gated-at.bofh.it> (permalink)
References	<tIGM1-4u0-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Just use the simplified rate limit printk when the max modprobe
limit is reached, while at it throw out a bone should the error
be triggered.

Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 kernel/kmod.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/kernel/kmod.c b/kernel/kmod.c
index 7ea11dbc7564..56cd2a16e7ac 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -166,7 +166,6 @@ int __request_module(bool wait, const char *fmt, ...)
 	va_list args;
 	char module_name[MODULE_NAME_LEN];
 	int ret;
-	static int kmod_loop_msg;
 
 	/*
 	 * We don't allow synchronous module loading from async.  Module
@@ -191,13 +190,8 @@ int __request_module(bool wait, const char *fmt, ...)
 
 	ret = kmod_umh_threads_get();
 	if (ret) {
-		/* We may be blaming an innocent here, but unlikely */
-		if (kmod_loop_msg < 5) {
-			printk(KERN_ERR
-			       "request_module: runaway loop modprobe %s\n",
-			       module_name);
-			kmod_loop_msg++;
-		}
+		pr_err_ratelimited("%s: module \"%s\" reached limit (%u) of concurrent modprobe calls\n",
+				   __func__, module_name, max_modprobes);
 		return ret;
 	}
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] kmod: use simplified rate limit printk "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-19 05:30 +0200
  Re: [PATCH 6/6] kmod: use simplified rate limit printk Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-20 00:30 +0200
    Re: [PATCH 6/6] kmod: use simplified rate limit printk Petr Mladek <pmladek@suse.com> - 2017-05-23 11:10 +0200

csiph-web