Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645165

Re: [PATCH] dmaengine: remove redundant null check on req

Show all headers | View raw

On Wed, May 17, 2017 at 12:12:00PM -0700, Dan Williams wrote:
> On Wed, May 17, 2017 at 6:35 AM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Req is never null on at the point of the null check, so
> > remove this redundant check and just return &req->tx.
> >
> > Detected by CoverityScan, CID#1436147 ("Logically dead code")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Hi Colin,
> 
> Looks good, can you also include the driver name in your patch subjects?
> 
> For example "dmaengine, bcm-scm-raid: remove redundant null check on
> req", would make it clear that this is a driver fix and not a core
> dmaengine issue.

Yeah that would help, also do the same for static patch you sent on the
driver.
-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dmaengine: remove redundant null check on req Colin King <colin.king@canonical.com> - 2017-05-17 15:40 +0200
  Re: [PATCH] dmaengine: remove redundant null check on req Dan Williams <dan.j.williams@intel.com> - 2017-05-17 21:20 +0200
    Re: [PATCH] dmaengine: remove redundant null check on req Vinod Koul <vinod.koul@intel.com> - 2017-05-19 05:30 +0200

csiph-web