Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1643478

Re: [PATCH-RFT 2/2] pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8

From Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH-RFT 2/2] pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8
Date 2017-05-17 17:50 +0200
Message-ID <tI9n3-4Ud-7@gated-at.bofh.it> (permalink)
References <tHQX8-1J7-21@gated-at.bofh.it> <tI00p-7v7-19@gated-at.bofh.it> <tHQX9-1J7-35@gated-at.bofh.it> <tI00p-7v7-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, May 17, 2017 at 07:43:51AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
> 
> On 2017-05-16 22:06, Krzysztof Kozlowski wrote:
> > Exynos pinctrl drivers contain pretty big per-SoC data structures.  The
> > pinctrl-exynos object file contained code and data for both ARMv7 and
> > ARMv8 SoCs thus it grew big.  There will not be a shared image between
> > ARMv7 and ARMv8 so there is no need to combine all of this into one
> > driver.
> > 
> > Splitting the data allows to make it more granular (e.g. code related to
> > ARMv8 Exynos is self-contained), slightly speed up the compilation and
> > reduce the effective size of compiled kernel.
> > 
> > The common data structures and functions reside still in existing
> > pinctrl-exynos.c.  Only the SoC-specific parts were moved out to new
> > files.  Except marking few functions non-static and adding them to
> > header, there were no functional changes in the code.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > 
> > Not tested on ARMv8 (Exynos5433, Exynos7).
> 
> Works fine on TM2 (Exynos5433).
> 
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

Great, thanks! Much appreciated.

Best regards,
Krzysztof

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] pinctrl: samsung: Split per ARMv7/v8 arch Krzysztof Kozlowski <krzk@kernel.org> - 2017-05-16 22:10 +0200
  [PATCH 1/2] pinctrl: samsung: Add include guard to local header Krzysztof Kozlowski <krzk@kernel.org> - 2017-05-16 22:10 +0200
  Re: [PATCH-RFT 2/2] pinctrl: samsung: Split Exynos drivers per ARMv7  and ARMv8 Krzysztof Kozlowski <krzk@kernel.org> - 2017-05-17 17:50 +0200
  Re: [PATCH-RFT 2/2] pinctrl: samsung: Split Exynos drivers per ARMv7  and ARMv8 Krzysztof Kozlowski <krzk@kernel.org> - 2017-05-20 19:20 +0200
  Re: [PATCH-RFT 2/2] pinctrl: samsung: Split Exynos drivers per ARMv7  and ARMv8 Linus Walleij <linus.walleij@linaro.org> - 2017-05-20 19:20 +0200
  Re: [PATCH 0/2] pinctrl: samsung: Split per ARMv7/v8 arch Alim Akhtar <alim.akhtar@gmail.com> - 2017-05-24 18:50 +0200

csiph-web