Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available
Date	2017-05-17 17:10 +0200
Message-ID	<tI8Km-4GH-23@gated-at.bofh.it> (permalink)
References	<tDraV-5t6-9@gated-at.bofh.it> <tDBah-3LK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 2017-05-05 11:21:41, Sergey Senozhatsky wrote:
> On (05/04/17 17:46), Petr Mladek wrote:
> [..]
> > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Signed-off-by: Petr Mladek <pmladek@suse.com>
> 
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Thanks for ack.

> a small nitpick,
> 
> [..]
> >  void printk_nmi_enter(void)
> >  {
> > -	this_cpu_or(printk_context, PRINTK_NMI_CONTEXT_MASK);
> > +	/*
> > +	 * The size of the extra per-CPU buffer is limited. Use it only when
> > +	 * the main one is locked. If this CPU is not in the safe context,
> > +	 * the lock must be taken on another CPU and we could wait for it.
> > +	 */
> > +	if (raw_spin_is_locked(&logbuf_lock) &&
> > +	    this_cpu_read(printk_context) & PRINTK_SAFE_CONTEXT_MASK) {
> > +		this_cpu_or(printk_context, PRINTK_NMI_CONTEXT_MASK);
> 
> could we please check `printk_context' (local to a particular CPU)
> first and, if positive, then access `logbuf_lock' (which is global)?

OK, I did so and queued the fix for-4.13, see
https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-4.13&id=ad30113010b7b2dd886923261aea7034de07cce6

Best Regards,
Petr

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock  is available Petr Mladek <pmladek@suse.com> - 2017-05-17 17:10 +0200

csiph-web