Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race with cpuset update

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race with cpuset update
Date	2017-05-17 17:00 +0200
Message-ID	<tI8AH-4o1-55@gated-at.bofh.it> (permalink)
References	(5 earlier) <tC4Jr-8ub-13@gated-at.bofh.it> <tI3rj-1fU-11@gated-at.bofh.it> <tI7EC-3KY-13@gated-at.bofh.it> <tI7Oi-43z-21@gated-at.bofh.it> <tI8qZ-4kw-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 17-05-17 09:48:25, Cristopher Lameter wrote:
> On Wed, 17 May 2017, Michal Hocko wrote:
> 
> > > > So how are you going to distinguish VM_FAULT_OOM from an empty mempolicy
> > > > case in a raceless way?
> > >
> > > You dont have to do that if you do not create an empty mempolicy in the
> > > first place. The current kernel code avoids that by first allowing access
> > > to the new set of nodes and removing the old ones from the set when done.
> >
> > which is racy and as Vlastimil pointed out. If we simply fail such an
> > allocation the failure will go up the call chain until we hit the OOM
> > killer due to VM_FAULT_OOM. How would you want to handle that?
> 
> The race is where? If you expand the node set during the move of the
> application then you are safe in terms of the legacy apps that did not
> include static bindings.

I am pretty sure it is describe in those changelogs and I won't repeat
it here.

> If you have screwy things like static mbinds in there then you are
> hopelessly lost anyways. You may have moved the process to another set
> of nodes but the static bindings may refer to a node no longer
> available. Thus the OOM is legitimate.

The point is that you do _not_ want such a process to trigger the OOM
because it can cause other processes being killed.

> At least a user space app could inspect
> the situation and come up with custom ways of dealing with the mess.

I do not really see how would this help to prevent a malicious user from
playing tricks.

-- 
Michal Hocko
SUSE Labs

Thread

Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Michal Hocko <mhocko@kernel.org> - 2017-05-17 11:30 +0200
  Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Christoph Lameter <cl@linux.com> - 2017-05-17 16:00 +0200
    Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Michal Hocko <mhocko@kernel.org> - 2017-05-17 16:10 +0200
      Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Christoph Lameter <cl@linux.com> - 2017-05-17 16:50 +0200
        Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Michal Hocko <mhocko@kernel.org> - 2017-05-17 17:00 +0200
          Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Christoph Lameter <cl@linux.com> - 2017-05-17 17:30 +0200
          Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Christoph Lameter <cl@linux.com> - 2017-05-17 17:30 +0200
            Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Michal Hocko <mhocko@kernel.org> - 2017-05-18 11:10 +0200
              Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Christoph Lameter <cl@linux.com> - 2017-05-18 19:00 +0200
                Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Michal Hocko <mhocko@kernel.org> - 2017-05-18 19:30 +0200
                Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Christoph Lameter <cl@linux.com> - 2017-05-18 21:10 +0200
                Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Michal Hocko <mhocko@kernel.org> - 2017-05-19 09:40 +0200
        Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race with  cpuset update Vlastimil Babka <vbabka@suse.cz> - 2017-05-18 12:10 +0200
          Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Christoph Lameter <cl@linux.com> - 2017-05-18 19:10 +0200
            Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race with  cpuset update Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 13:30 +0200

csiph-web