Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643320

Re: [PATCH 00/22] hisi_sas: hip08 support

Show all headers | View raw

On Wed, May 17, 2017 at 12:49 PM, John Garry <john.garry@huawei.com> wrote:
> This patchset adds support for the HiSilicon SAS controller
> in the hip08 chipset.
>
> The key difference compared to earlier chipsets is that the
> controller is an integrated PCI endpoint in hip08.
> As such, the controller is a pci device (not a platform device,
> like v2 hw in hip07).
>
> The driver is refactored so it can support both platform and
> pci device-based controllers.
>
> File hisi_sas_pci_init.c is introduced for pci device probing
> and initialization. Common functionality is still in
> hisi_sas_main.c, along with platform device probing and
> initialization.
>
> New hw layer file hisi_sas_v3_hw.c is added for hip08
> controller support. HW revisions v2 and v3 are very similar,
> but it was decided to keep support in separate files for now.
>
> As for the patches, (ignoring #1 and #2) the first few
> reorganise some functions from v2 hw.c into main.c, as they
> are required for v3 hw. Then support is added for pci
> device-based controller in subsequent patches.
> And then hip08 support is added in the final patches.

Looks good overall, but I have some high-level comments
on a couple of patches. I'm sure we can resolve them all
easily.

      Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/22] hisi_sas: hip08 support John Garry <john.garry@huawei.com> - 2017-05-17 12:30 +0200
  [PATCH 05/22] scsi: hisi_sas: relocate get_ncq_tag_v2_hw() John Garry <john.garry@huawei.com> - 2017-05-17 12:30 +0200
  [PATCH 14/22] scsi: hisi_sas: add v3 code to send SSP frame John Garry <john.garry@huawei.com> - 2017-05-17 12:30 +0200
  [PATCH 16/22] scsi: hisi_sas: add v3 code to send ATA frame John Garry <john.garry@huawei.com> - 2017-05-17 12:30 +0200
  [PATCH 04/22] scsi: hisi_sas: relocate sata_done_v2_hw() John Garry <john.garry@huawei.com> - 2017-05-17 12:30 +0200
  Re: [PATCH 00/22] hisi_sas: hip08 support Arnd Bergmann <arnd@arndb.de> - 2017-05-17 14:40 +0200

csiph-web