Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643252

Re: [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables

Show all headers | View raw

On Wed, May 17, 2017 at 1:25 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Make sure dmi_system_id tables are NULL terminated.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>  drivers/pinctrl/intel/pinctrl-cherryview.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 2debba62fac9..e35d0fe4c737 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -1547,7 +1547,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
>                         DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"),
>                         DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
>                 },
> -       }
> +       },
> +       {}
>  };
>
>  static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq)
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-17 12:30 +0200
  Re: [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for  dmi_system_id tables Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-17 12:40 +0200
  Re: [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for  dmi_system_id tables Linus Walleij <linus.walleij@linaro.org> - 2017-05-23 10:20 +0200

csiph-web